Skip to content

Conversation

@zombieJ
Copy link
Member

@zombieJ zombieJ commented Dec 14, 2021

@vercel
Copy link

vercel bot commented Dec 14, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/tree-select/6n7fe1pZPR58xBZMR1stw9bf6Hjv
✅ Preview: https://tree-select-git-base-select-react-component.vercel.app

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Dec 14, 2021

This pull request introduces 15 alerts when merging 5343d49 into 36a9fc5 - view on LGTM.com

new alerts:

  • 14 for Unused variable, import, function or class
  • 1 for Superfluous trailing arguments

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Dec 14, 2021

This pull request introduces 15 alerts when merging 39187b8 into 36a9fc5 - view on LGTM.com

new alerts:

  • 14 for Unused variable, import, function or class
  • 1 for Superfluous trailing arguments

@zombieJ zombieJ changed the title refactor: Move TreeSelect calculation out of BaseSelect [WIP] refactor: Move TreeSelect calculation out of BaseSelect Dec 14, 2021
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Dec 14, 2021

This pull request introduces 15 alerts when merging 67c7d89 into 36a9fc5 - view on LGTM.com

new alerts:

  • 14 for Unused variable, import, function or class
  • 1 for Superfluous trailing arguments

@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #393 (82af61f) into master (c290204) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #393   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        14    +2     
  Lines          548       462   -86     
  Branches       163       123   -40     
=========================================
- Hits           548       462   -86     
Impacted Files Coverage Δ
src/LegacyContext.tsx 100.00% <100.00%> (ø)
src/OptionList.tsx 100.00% <100.00%> (ø)
src/TreeSelect.tsx 100.00% <100.00%> (ø)
src/TreeSelectContext.ts 100.00% <100.00%> (ø)
src/hooks/useCache.ts 100.00% <100.00%> (ø)
src/hooks/useCheckedKeys.ts 100.00% <100.00%> (ø)
src/hooks/useDataEntities.ts 100.00% <100.00%> (ø)
src/hooks/useFilterTreeData.ts 100.00% <100.00%> (ø)
src/hooks/useRefFunc.ts 100.00% <100.00%> (ø)
src/hooks/useTreeData.ts 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36a9fc5...82af61f. Read the comment docs.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Dec 14, 2021

This pull request introduces 15 alerts when merging d2aed86 into 36a9fc5 - view on LGTM.com

new alerts:

  • 14 for Unused variable, import, function or class
  • 1 for Superfluous trailing arguments

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Dec 14, 2021

This pull request introduces 7 alerts when merging a27135e into 36a9fc5 - view on LGTM.com

new alerts:

  • 7 for Unused variable, import, function or class

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Dec 14, 2021

This pull request introduces 6 alerts when merging ad35834 into 36a9fc5 - view on LGTM.com

new alerts:

  • 6 for Unused variable, import, function or class

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Dec 14, 2021

This pull request introduces 6 alerts when merging ec01304 into 36a9fc5 - view on LGTM.com

new alerts:

  • 6 for Unused variable, import, function or class

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Dec 14, 2021

This pull request introduces 4 alerts when merging 82af61f into 36a9fc5 - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class

@zombieJ zombieJ changed the title [WIP] refactor: Move TreeSelect calculation out of BaseSelect refactor: Move TreeSelect calculation out of BaseSelect Dec 14, 2021
@zombieJ zombieJ merged commit ad48ba5 into master Dec 14, 2021
@zombieJ zombieJ deleted the base-select branch December 14, 2021 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants